Skip to content

feat: Add validating addmission webhook for ALB Ingress annotations#1119

Open
kamilprzybyl wants to merge 2 commits into
feat/kp/add-alb-ingress-controllerfrom
feat/kp/validating-addmission-webhook
Open

feat: Add validating addmission webhook for ALB Ingress annotations#1119
kamilprzybyl wants to merge 2 commits into
feat/kp/add-alb-ingress-controllerfrom
feat/kp/validating-addmission-webhook

Conversation

@kamilprzybyl
Copy link
Copy Markdown

How to categorize this PR?

What this PR does / why we need it:

This PR introduces a Validating Admission Webhook to enforce mandatory STACKIT annotations (like alb.stackit.cloud/network-mode) on Ingress resources. It prevents invalid Ingresses from being created in the cluster if they do not meet the ALB controller's requirements.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jamand for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2026
@kamilprzybyl kamilprzybyl force-pushed the feat/kp/validating-addmission-webhook branch from 6761736 to 54c68e1 Compare May 15, 2026 13:02
@kamilprzybyl kamilprzybyl changed the title feat: add validating addmission webhook for ALB Ingress annotations feat: Add validating addmission webhook for ALB Ingress annotations May 15, 2026
@ske-prow
Copy link
Copy Markdown

ske-prow Bot commented May 15, 2026

@kamilprzybyl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-stackit-verify 02fdbf8 link true /test pull-cloud-provider-stackit-verify

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see the gardener testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant