WIP: Rocky 10 migration documentation - #2501
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughAdds a Rocky Linux 9 to Rocky Linux 10 migration guide. The guide covers configuration updates, Release Train synchronisation, Valkey migration, host migration procedures, Ceph and OVN handling, validation, and optional image builds. It also adds the guide to the operations documentation index. WalkthroughAdded a Rocky Linux 10 migration guide. The guide covers preparation, controller migration, compute migration, storage migration, validation, and pending Seed and Ansible control host procedures. ChangesRocky Linux 10 migration documentation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3785112 to
b8060f6
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 35bae627-3ef7-476d-bef6-3c56838ee25b
📒 Files selected for processing (2)
doc/source/operations/index.rstdoc/source/operations/rocky-10.rst
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: Ansible 2.18 lint with Python 3.12
- GitHub Check: Ansible 2.17 lint with Python 3.10
⚠️ CI failures not shown inline (1)
GitHub Check: stackhpc/check: Summary
Conclusion: failure
Build failed.
https://zuul.stackhpc.com/t/stackhpc/buildset/ea31208958534febb947f3c2e11f0fcb
:x: [openstack-tox-pep8 ](https://zuul.stackhpc.com/t/stackhpc/build/fac7cad584fa4d7085ba945cda5613a2) **NODE_FAILURE** Node(set) request 200-0000005947 failed in 0s
🔇 Additional comments (9)
doc/source/operations/index.rst (1)
27-27: LGTM!doc/source/operations/rocky-10.rst (8)
24-54: LGTM!
81-102: LGTM!
112-190: LGTM!
206-211: LGTM!Also applies to: 216-239
241-265: LGTM!Also applies to: 281-302, 320-324
337-378: LGTM!Also applies to: 395-399
17-22: 🗄️ Data Integrity & IntegrationDo not add
kolla_base_distro_versionto this step.
kolla/kolla.ymlalready setskolla_base_distro_version_default_mapwith"rocky": "{{ ansible_facts.distribution_major_version }}", andkolla/kolla.ymluseskolla_base_distro_version_default_map[kolla_base_distro]for the selected Kolla image version.> Likely an incorrect or invalid review comment.
69-79: 🎯 Functional CorrectnessDo not change the Valkey pull command to
--kolla-tags.Line 73 currently uses
--kolla-tag valkey, while--kolla-tagsis used in these docs for service scoping. The issue has not been established.
|
|
||
| #. If the controller is running Ceph OSD services: | ||
|
|
||
| #. **Deploy public key/install cephadm - this step needs checking** |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== file location =="
git ls-files | grep -F 'doc/source/operations/rocky-10.rst' || true
echo
echo "== relevant lines =="
if [ -f doc/source/operations/rocky-10.rst ]; then
nl -ba doc/source/operations/rocky-10.rst | sed -n '190,230p;290,310p;370,388p'
fi
echo
echo "== search ceph placeholders/procedures =="
rg -n "this step needs checking|cephadm|ceph-exit-maintenance|public key|rejoin|storage migration|controller migration" doc/source/operations/rocky-10.rst .github doc/source 2>/dev/null || true
echo
echo "== repo-level ceph references =="
rg -n "ceph-adm|cephadm|ceph-exit-maintenance|public key|publickey|deploy public key|install cephadm" . -g '!/.git' -g '!node_modules' 2>/dev/null | head -n 200Repository: stackhpc/stackhpc-kayobe-config
Length of output: 287
🏁 Script executed:
#!/bin/bash
set -euo pipefail
sed -n '190,230p' doc/source/operations/rocky-10.rst
sed -n '290,310p' doc/source/operations/rocky-10.rst
sed -n '370,388p' doc/source/operations/rocky-10.rst
echo
echo "== search ceph placeholders/procedures =="
rg -n "this step needs checking|cephadm|ceph-exit-maintenance|public key|rejoin|storage migration|controller migration" doc/source/operations/rocky-10.rst doc/source 2>/dev/null || true
echo
echo "== repo ceph references =="
rg -n "ceph-adm|cephadm|ceph-exit-maintenance|public key|publickey|deploy public key|install cephadm" . --glob '!/.git' --glob '!node_modules' 2>/dev/null | head -n 200 || trueRepository: stackhpc/stackhpc-kayobe-config
Length of output: 37402
Replace the Ceph placeholder with a checked rejoin procedure.
At doc/source/operations/rocky-10.rst:214, :305, and :380, remove “Deploy public key/install cephadm - this step needs checking” and replace it with validated public-key, cephadm, and cluster rejoin steps before running kayobe playbook run $KAYOBE_CONFIG_PATH/ansible/ceph/ceph-exit-maintenance.yml ... and ceph -s.
| Potential Issues | ||
| ---------------- | ||
| TBC |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | 🏗️ Heavy lift
Complete or clearly scope the unfinished sections.
The guide leaves the compute and storage “Potential Issues” sections as TBC and leaves Seed and Ansible Control Host procedures as TODO. Operators cannot use this as a complete migration runbook until these sections contain verified procedures or explicit scope exclusions with authoritative links. I can help draft the missing sections.
Also applies to: 340-342, 401-407
b8060f6 to
7ea499e
Compare
7ea499e to
f21ac44
Compare
f21ac44 to
e953943
Compare
Documentation to cover the migration from Rocky Linux 9 to Rocky Linux 10 has been added.
e953943 to
e5321f7
Compare
1 participant
Documentation to cover the migration from Rocky Linux 9 to Rocky Linux 10 has been added.