Skip to content

feat: update RL9 overcloud host image#2199

Closed
jackhodgkiss wants to merge 1 commit intostackhpc/2025.1from
update-overcloud-image
Closed

feat: update RL9 overcloud host image#2199
jackhodgkiss wants to merge 1 commit intostackhpc/2025.1from
update-overcloud-image

Conversation

@jackhodgkiss
Copy link
Contributor

No description provided.

Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
@jackhodgkiss jackhodgkiss self-assigned this Mar 6, 2026
@jackhodgkiss jackhodgkiss requested a review from a team as a code owner March 6, 2026 21:22
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version for the Rocky Linux 9 overcloud host image. My review has identified a potential inconsistency between this change and the associated release note. The PR updates a single image, while the release note implies multiple images were rebuilt. Please see the specific comment for details.

# Overcloud host image versioning tags
# These images must be in SMS, since they are used by our AIO CI runners
stackhpc_rocky_9_overcloud_host_image_version: 2025.1-20260206T132408
stackhpc_rocky_9_overcloud_host_image_version: 2025.1-20260306T094256
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change introduces a potential inconsistency. The associated release note (releasenotes/notes/host-image-rebuild-957b0a69de1044fc.yaml) states that 'overcloud host images' (plural) have been rebuilt. This suggests that both the Rocky 9 and Ubuntu Noble images should have new versions. However, only the Rocky 9 image version is being updated here. If the Ubuntu image was also rebuilt, its version should be updated as well to ensure consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant