Make Rabbit reset playbook hosts configurable#2197
Open
Alex-Welsh wants to merge 1 commit intostackhpc/2025.1from
Open
Make Rabbit reset playbook hosts configurable#2197Alex-Welsh wants to merge 1 commit intostackhpc/2025.1from
Alex-Welsh wants to merge 1 commit intostackhpc/2025.1from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request makes the host groups in the RabbitMQ reset playbook configurable, which is a good step towards more flexible deployments. However, I've found an issue where a hardcoded value remains, which could cause the playbook to fail if the new configuration variables are used. The task that waits for RabbitMQ nodes to come online still refers to the controllers group, instead of dynamically using the hosts provided for the play.
Alex-Welsh
force-pushed
the
rabbit-reset-hosts
branch
from
0f74467 to
8e7a983
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RabbitMQ sometimes runs on nodes that aren't the controllers. These values would benefit from being configurable