Synchronise 2026.1 with upstream#15
Merged
Merged
Conversation
When all_squash=true metadata is set on an NFS share and access rules are updated on a readable DP (data protection) replica, the driver was calling set_pcuser_for_volume on the SnapMirror destination volume. ONTAP rejects this with error code 160 because DP volumes are read-only and their user attribute cannot be modified. Fix by propagating the replica flag (True for non-active readable DP replicas, False otherwise) from lib_base into the NFS protocol helper update_access() method. When replica=True the pcuser configuration step is skipped with an informational log message. The replica flag is set correctly in all callers: - update_access(): True for non-active readable replicas (DP volumes) - create_replica(): True (new replica is a DP volume) - promote_replica(): False (promoted replica becomes read-write) - _safe_change_replica_source(): True (old source becomes new DP target) Change-Id: I48fd7e4aced6c14fcd6dae053833ff786ec507df Signed-off-by: Kiran Pawar <kinpaa@gmail.com> (cherry picked from commit 74a8848)
When free_capacity_gb, total_capacity_gb, or provisioned_capacity_gb is None, the weigher previously raised a TypeError by attempting arithmetic with None. Following the existing 'unknown' treatment, None values are now handled as worst-case (sorts to bottom), which is safer than assuming zero provisioned capacity. Closes-bug: #2145805 Change-Id: I6e7e9dce772beebadd6199039aed5906e6ba24e6 Signed-off-by: Kiran Pawar <kinpaa@gmail.com> (cherry picked from commit 3c04a17)
github-actions
Bot
added
automated
Member
|
Merged in stackhpc/2026.1, and CI is running now |
Member
|
Not sure why it needed manual intervention though |
Alex-Welsh
approved these changes
Jun 3, 2026
mnasiadka
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of 2026.1 from upstream stable/2026.1.