Skip to content

refactor: extract dereference/validate pipeline from reconcile#1034

Open
maltesander wants to merge 9 commits into
mainfrom
feat/dereference-validate-steps
Open

refactor: extract dereference/validate pipeline from reconcile#1034
maltesander wants to merge 9 commits into
mainfrom
feat/dereference-validate-steps

Conversation

@maltesander
Copy link
Copy Markdown
Member

Description

  • added dereference and validate steps for zk and znode controller

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 moved this to Development: In Review in Stackable Engineering May 20, 2026
@adwk67 adwk67 self-requested a review May 20, 2026 16:12
Copy link
Copy Markdown
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are all good. One comment from my initial look.

};
let validate::ValidatedInputs {
zookeeper_security, ..
} = validate::validate(&znode, &dereferenced, &ctx.operator_environment)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will try and resolve the image (unnecessarily, at this point) so if the image is not found the clean up will exit "uncleanly" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

2 participants