Skip to content

feat: Allow tweaking catalog name in Trino#903

Merged
sbernauer merged 9 commits into
mainfrom
feat/catalog-name-underscores
Jul 7, 2026
Merged

feat: Allow tweaking catalog name in Trino#903
sbernauer merged 9 commits into
mainfrom
feat/catalog-name-underscores

Conversation

@sbernauer

@sbernauer sbernauer commented Jun 24, 2026

Copy link
Copy Markdown
Member

Description

Part of #891

Sadly we could not agree on the custom part (yet), so we keep that for the later.

I also included two things:

  1. Introduce TrinoCatalogName, which is a new type wrapper around String
  2. Changed Vec<CatalogConfig> to BTreeMap<TrinoCatalogName, CatalogConfig> so that it's guaranteed we never end up with the same catalog name twice

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

Release notes

Add a new .spec.name.inferred.replaceHyphensWithUnderscores field on TrinoCatalog, which allows tweaking the catalog name in Trino by replacing - with _. This allows you to use valid Kubernetes names, but keeps the convenience of _ in catalog names.

@sbernauer sbernauer force-pushed the feat/catalog-name-underscores branch from 9a938a3 to e306fc1 Compare July 6, 2026 13:59
Comment thread docs/modules/trino/pages/usage-guide/catalogs/index.adoc Outdated
Comment thread docs/modules/trino/pages/usage-guide/catalogs/index.adoc Outdated
Comment thread docs/modules/trino/pages/usage-guide/catalogs/index.adoc Outdated
Comment thread rust/operator-binary/src/catalog/commons.rs Outdated
Comment thread rust/operator-binary/src/controller/dereference.rs Outdated
Comment thread rust/operator-binary/src/crd/catalog/mod.rs Outdated
Comment thread rust/operator-binary/src/crd/catalog/mod.rs Outdated
Comment thread rust/operator-binary/src/crd/catalog/mod.rs Outdated
Comment thread rust/operator-binary/src/crd/catalog/mod.rs Outdated
@sbernauer sbernauer requested a review from maltesander July 7, 2026 07:36
Comment thread rust/operator-binary/src/controller/dereference.rs Outdated
maltesander
maltesander previously approved these changes Jul 7, 2026

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added release/26.7.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 7, 2026
@sbernauer sbernauer self-assigned this Jul 7, 2026
@sbernauer sbernauer enabled auto-merge July 7, 2026 09:42
@sbernauer sbernauer disabled auto-merge July 7, 2026 09:42
@sbernauer

Copy link
Copy Markdown
Member Author

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/83/

@sbernauer sbernauer added this pull request to the merge queue Jul 7, 2026
Merged via the queue into main with commit d846449 Jul 7, 2026
18 checks passed
@sbernauer sbernauer deleted the feat/catalog-name-underscores branch July 7, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/26.7.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants