fix: reuse HttpClient instance across authorize() calls#143
Open
vikshab wants to merge 2 commits intostackabletech:mainfrom
Open
fix: reuse HttpClient instance across authorize() calls#143vikshab wants to merge 2 commits intostackabletech:mainfrom
vikshab wants to merge 2 commits intostackabletech:mainfrom
Conversation
Creating a new HttpClient on every authorize() call spawns a new SelectorManager thread each time, causing thread exhaustion under load. HttpClient is thread-safe and designed to be reused — move it to an instance field initialized once in the constructor.
Member
|
Hi @vikshab, thank you, LGTM, would you mind adding a changelog entry under "unreleased" and a new section "### Fixed" ? druid-opa-authorizer/CHANGELOG.md Line 9 in 31a6568 I can do it as well. Malte |
Author
@maltesander Pushed new commit |
Member
|
Hey thank you, but this is in the wrong place. I meant something like this (from the top): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #142 issue
Problem
Each call to
OpaAuthorizer.authorize()creates a newHttpClientviaHttpClient.newHttpClient(). EveryHttpClientspawns aSelectorManagerbackground thread and its own connection pool that are never shut down, causing unbounded thread growth under load.Fix
Move
HttpClientto an instance field initialized once in the constructor.HttpClientis thread-safe and designed to be reused — a single instance handles all concurrent requests via its internal connection pool, eliminating the thread leak