Skip to content

No more registry pushes for dependabot builds - #364

Merged
Bohreromir merged 2 commits into
mainfrom
fix/no-dependabot-image-pushes
Oct 8, 2026
Merged

Bohreromir merged 2 commits into
mainfrom
fix/no-dependabot-image-pushes

Conversation

@Bohreromir

Copy link
Copy Markdown
Member

No description provided.

@Bohreromir Bohreromir self-assigned this Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 51.08% 2498 / 4890
🔵 Statements 57.16% 3714 / 6497
🔵 Functions 65.83% 1031 / 1566
🔵 Branches 42.96% 1298 / 3021
File CoverageNo changed files found.
Generated in workflow #1048 for commit daa5223 by the Vitest Coverage Report Action

@StefanFl
StefanFl self-requested a review October 8, 2026 08:39
@StefanFl

StefanFl commented Oct 8, 2026

Copy link
Copy Markdown
Member

Claude found one gap:

finished only looks at openshift-preflight-check and publish-helm-chart. If build-container-image fails, both of those are skipped, so finished passes. For Dependabot PRs the build is now the only real check in this workflow, so a dependency bump that breaks the Docker build can merge with a green required check. The failing job only shows up as a non-required red check.

Fix in .github/workflows/build.yaml, job finished:

  • add build-container-image and publish-index-manifest to needs
  • replace the two-job comparison with contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') (pass the JSON in via env, not inline ${{ }} in the script)

@Bohreromir
Bohreromir merged commit 205e323 into main Oct 8, 2026
12 checks passed
@Bohreromir
Bohreromir deleted the fix/no-dependabot-image-pushes branch October 8, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Waiting for Review

Development

Successfully merging this pull request may close these issues.

2 participants