S3 File Browser v2

[F3l1x1vo]

Closes #124 #180 #216

[github-actions]

⚠️ Coverage report too large to inline, see the workflow summary.

[Bohreromir]

Due to time constrains I can only supply you with a spot checked by me, clauded review for now.
Feel free to push back on any hallucinated ones ;)

High

• src/lib/server/storage/operations.ts:121 – With destinationKey set (used by rename), only sourceKeys[0] is copied, so renaming a folder only moves its / marker and leaves the contents behind. Expand directory keys here the way computeDestinations does.
• src/lib/server/storage/operations.ts:198 – Moves filter out keys ending in / before deleting, so the source folder marker survives and an empty folder stays visible. Delete the markers once all their children have moved.
• src/lib/server/storage/preview/csv.ts:112,125,141 – Line offsets use JS string length (UTF-16) instead of UTF-8 byte length, so any non-ASCII character shifts every later offset and garbles rows. Count with TextEncoder().encode(line).length or scan the raw bytes for \n.
• src/lib/server/auth.ts:97 – Regression: email: profile.email || '' dropped the preferred_username fallback. better-auth rejects an empty email (email_is_missing), so OIDC users without an email claim can't log in any more.

Medium

• src/lib/server/storage/operations.ts:141 – uniqueDestKey runs per expanded child, not once for the folder root. Copying docs/ where docs/ already exists gives an empty docs (1)/, with the files landing in docs/ as a (1).txt.
• src/lib/server/storage/preview/csv.ts:225 – Cached entries are never checked against the file's ETag or size, and nothing clears them. After a save or re-upload the preview reads the wrong ranges until the TTL expires.
• src/lib/server/storage/connections-db.ts:21 – The fingerprint leaves out port, TLS and access style, so connecting to the same host on another port silently reuses the old connection. Add them to the hash.
• src/routes/(app)/settings/connections/[id]/edit/+page.server.ts:170 – An edit re-encrypts the payload but never updates hash. A later connect with the old settings then matches the edited connection.
• src/lib/storage/upload.ts:42 – Regression: checkObjectExists returns false on any non-2xx or network error, so a 401, 403 or 5xx skips the overwrite prompt. Restore the main behaviour: 404 means false, everything else throws (the docstring still says it throws).
• src/lib/server/storage/download-manifests.ts:320 – The single-file download pipes into controller.enqueue with no backpressure, so a large file to a slow client is buffered in Node memory. Return download.stream directly or use pull.
• src/routes/(app)/api/storage/download/manifests/[manifestId]/[part]/+server.ts:31 – The raw filename goes into filename="...", so non-Latin-1 names cause a 500 and a " breaks the header. Reuse contentDispositionFilename from download/+server.ts.
• src/lib/server/storage/streaming.ts:57 – If operationPromise rejects (for example listAllKeys fails), the job is never failed and stays running until it expires. Wrap the call in try/catch → failJob, then error the stream.

Low

• src/routes/(app)/settings/connections/[id]/edit/+page.server.ts:92 – If only one of access key or secret is filled in, the change is dropped and the page still reports success. Return a validation error instead.
• src/routes/(app)/settings/connections/[id]/edit/+page.server.ts:155,162 – 'Connection not found' and 'Failed to read existing credentials' are hardcoded user-visible strings. Move them to messages/*.json.
• src/lib/server/storage/download-manifests.ts:73 – expandKeys sends one getMetadata HEAD per key through Promise.all with no limit, so a large folder fires thousands at once. Use the sizes from the listing or cap concurrency.
• src/lib/server/storage/connection.ts:38 – A connection-ID header that isn't a valid UUID reaches Postgres and returns 500. Validate it as a UUID first and return 400/401.