Repository navigation
fix(translations): fix broken parameters, drop plural suffix, add missing languages - #45
Merged
Merged
Conversation
Rushaway
changed the title
…al suffixes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rushaway
force-pushed
the
fix/translations
branch
from
September 30, 2026 13:05
f03a379 to
0695fd8
Compare
The "s" suffix passed as {3}/{5} only worked in English, French, German
and Portuguese; other languages ignored it. Reword the warnings as
"previous bans: {2}" so every language reads correctly for any count,
and stop passing the suffix from sbpp_checker. Adds da, es, nl, no, sv.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tions Every phrase is now translated in every language already used by the plugin translations, so smtranslate reports 0 errors and 0 warnings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rushaway
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
Brings the plugin translations to 0 errors, 0 warnings with the
Translationscheck (#46).Broken parameters
sbpp_comms/Permamuted player reason(chi): used{3}, but#formatonly declares 2 parameters. SourceMod printed{3}literally and never showed the reason. It's now{2}.sbpp_comms/Player already gagged(tr):{1]instead of{1}, so the player name was never inserted.Plural suffix in
sbpp_checkerThe connect warnings passed the English plural
"s"as{3}/{5}("previous ban{3}"). It only worked in English, French, German and Portuguese. Other languages either appended it to their own words ("забанен 2 разs", "封禁s") or dropped it.The phrases now read
previous bans: {2}in every language, which is correct for any count.sbpp_checker.spno longer passes the suffix (#formatgoes from{1:N},{2:d},{3:s}to{1:N},{2:d}, and{1:N},{2:d},{3:d}for the combined warning).Missing translations
Every phrase is now translated in every language already used by the translations:
sbpp_commssbpp_mainsbpp_reportsbpp_sleuthsbpp_checkerTerms used consistently per language: mute → voice (
mutet/gemute/dempet/tystad), gag → text chat block (chatblokering/chatblokkade/chatblokkering/chattblockering), silence → full block. Command keywords (!noreason,cancel) stay untranslated.Plugin version bumped to
1.8.5(sbpp_comms).sbpp_checkerfollowsSB_VERSION.Checks
Translations: 0 error(s), 0 warning(s) (languages: en, chi, da, de, es, fr, hu, nl, no, pl, pt, ru, sv, tr)Compile SourceMod plugins: pass🤖 Generated with Claude Code