Skip to content

fix(game): close DataPack ownership leaks and stale client-index reuse in the ban flow #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rushaway merged 7 commits into from
Sep 26, 2026
Merged

fix(game): close DataPack ownership leaks and stale client-index reuse in the ban flow #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b3f70b1
fix(game): clean up nested DataPack handles in the ban flow
Rushaway Sep 18, 2026
9ffc859
fix(game): stop double-freeing DataPack in Query_UnBlockSelect
Rushaway Sep 18, 2026
3b6d07e
fix(game): close out remaining Timer/DataPack/KeyValues lifecycle bugs
Rushaway Sep 18, 2026
794a55b
fix(game): resolve ban-flow admin/target by userid, not raw client index
Rushaway Sep 22, 2026
b137200
fix(game): fix SQLite ban-queue reprocessing bugs found while porting…
Rushaway Sep 22, 2026
929ef65
fix(game): don't abort temp-ban queueing when the target already left
cmer81 Sep 26, 2026
1747b6e
fix(game): keep retrying the SQLite ban queue after a failed SELECT
cmer81 Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions game/addons/sourcemod/scripting/sbpp_comms.sp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1627,12 +1627,14 @@ public void Query_UnBlockSelect(Database db, DBResultSet results, const char[] e
if (g_MuteType[target] > bNot)
{
dataPack.WriteCell(TYPE_UNMUTE);
TempUnBlock(dataPack);
TempUnBlock(dataPack); // Datapack closed inside.
return;
}
else if (g_GagType[target] > bNot)
{
dataPack.WriteCell(TYPE_UNGAG);
TempUnBlock(dataPack);
TempUnBlock(dataPack); // Datapack closed inside.
return;
}
}
}
Expand Down Expand Up @@ -3136,6 +3138,8 @@ stock void CreateMuteExpireTimer(int target, int remainingTime = 0)
{
if (g_iMuteLength[target] > 0)
{
CloseMuteExpireTimer(target);

DataPack dataPack;

if (remainingTime)
Expand All @@ -3152,6 +3156,8 @@ stock void CreateGagExpireTimer(int target, int remainingTime = 0)
{
if (g_iGagLength[target] > 0)
{
CloseGagExpireTimer(target);

DataPack dataPack;

if (remainingTime)
Expand Down
Loading
Loading