Repository navigation
fix(comments): stop hyperlinks truncating at hyphens - #30
Merged
Merged
Conversation
The auto-linkify regex for comment URLs used [\w/_\.]* for the path segment, which excludes '-'. A link like https://youtu.be/T1MnG-gKgF0 was rendered as a clickable https://youtu.be/T1MnG followed by plain-text -gKgF0. Added '-' to the path character class in all three places this regex is duplicated. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[\w/_\.]*) didn't include-https://youtu.be/T1MnG-gKgF0rendered as a clickablehttps://youtu.be/T1MnGfollowed by plain-text-gKgF0-to the path character class in all three duplicated occurrences of this regexTest plan
https://youtu.be/T1MnG-gKgF0locally withphp -r— full URL now links correctly🤖 Generated with Claude Code