refactor: use new-style declarations and methodmaps - #29
Merged
Merged
Conversation
- Enable `#pragma newdecls required` and convert all old-style declarations - Replace Handle-based APIs with Menu, Cookie, KeyValues and Event methodmaps - Use `delete` instead of CloseHandle - Deduplicate the visibility toggle logic - Bump version to 1.2.0 Closes #28 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
Changes
#pragma newdecls required(placed after includes) and convert every old-style declaration (new,decl,Float:,String:,Handle:tags)Menu(new Menu,AddItem,GetItem,Display,DisplayAt,Selection,ItemCount,RemoveAllItems)Cookie(new Cookie,Get/Set)KeyValues(ImportFromFile,GetNum/GetFloat/GetString,JumpToKey, …)Event(GetInt/GetFloat)deleteinstead ofCloseHandlebool:/Float:retagging with explicit comparisonsCommand_TracersVisibilitynow reusesTracersVisibility(nowvoid) instead of duplicating itint[] iClients = new int[MaxClients]No functional changes intended: cookie names, config keys, menus and chat output are unchanged. The
Cookiemethodmap needs SM 1.11+, which is already the documented minimum.🤖 Generated with Claude Code