Skip to content

ci: workflows install the editable package with --no-build-isolation (Part of #4918) - #5425

Merged
squid-protocol merged 1 commit into
mainfrom
churn/4918-20261018T0740Z
Oct 18, 2026
Merged

squid-protocol merged 1 commit into
mainfrom
churn/4918-20261018T0740Z

Conversation

@squid-protocol

Copy link
Copy Markdown
Owner

Part of #4918 (closes the pip install -e . build-isolation gap listed in #4944).

Workflow editable installs built with isolation fetched an unpinned setuptools/setuptools_scm. Every pip install -e in .github/workflows now passes --no-build-isolation, using the backend from the hash-locked ci/requirements/bootstrap.txt (#5355).

  • 29 workflows, 38 one-line changes (the owner patch from the churn handoffs dir, applied unchanged; mechanical, hence the file count).
  • tests/core_engine/test_ci_install_pins.py: removed the strict xfail on test_workflows_build_without_isolation; it now enforces the rule.
  • tests/tools/test_pr_gates_fleet.py: the mypy-audit assertion still named the removed tests/requirements-mypy.txt (stale since ci: hash-lock the mypy toolchain; local installs use the locked backend (Part of #4918) #5355); now names ci/requirements/mypy.txt.

Needs owner review: workflow files are CODEOWNERS-protected. A job that lacks the bootstrap lock install before the editable install would fail; the gate test checks every workflow for this.

Class table

Member Status
workflow pip install -e (all variants: ., ./gitgalaxy, ./main, extras) fixed here
publish.yml python -m build (isolated) sibling gap
workflow pip install -r requirements.txt (smoke-test, full-suite-gate, os-smoke-grid), unhashed sibling gap
tests/tools venv scripts (crucible_check) local pip install -e local tooling

No burned mainframe estate needs any of these. No golden bless (no parsing change).

Gates: pr_gates --fast 6/6, --ratchets 8/8, audit_check.py clear, tests/tools 1358 pass. One failure not caused by this change: test_pin_requirements_check_all reports ci/requirements/pytest.txt and test.txt STALE (lockfiles untouched here; likely the local pip-compile environment, not re-checked on main).

Cross-repo: none.

🤖 Generated with Claude Code

…(Part of #4918)

Applies the owner patch across 29 workflows so the hash-locked bootstrap backend is used, drops the
strict xfail in test_ci_install_pins, and fixes a stale mypy-audit assertion left by #5355.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-protocol

Copy link
Copy Markdown
Owner Author

Waiting on an owner decision (asked privately, 2026-10-18). Nothing is needed from contributors; work resumes once it is answered.

@squid-protocol squid-protocol added the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Oct 18, 2026
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol
squid-protocol marked this pull request as ready for review October 18, 2026 12:12
@github-actions

Copy link
Copy Markdown
Contributor

🐦‍⬛ Muninn Security Scan

✅ No security issues found.

🐦‍⬛ Powered by Muninn · Skald Lab

@squid-protocol
squid-protocol enabled auto-merge (squash) October 18, 2026 12:22
@squid-protocol
squid-protocol merged commit 63a0f27 into main Oct 18, 2026
94 checks passed
@squid-protocol
squid-protocol deleted the churn/4918-20261018T0740Z branch October 18, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant