Repository navigation
ci: workflows install the editable package with --no-build-isolation (Part of #4918) - #5425
Merged
Merged
Conversation
Owner
Author
|
Waiting on an owner decision (asked privately, 2026-10-18). Nothing is needed from contributors; work resumes once it is answered. |
Owner
Author
|
No description provided. |
squid-protocol
marked this pull request as ready for review
October 18, 2026 12:12
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4918 (closes the
pip install -e .build-isolation gap listed in #4944).Workflow editable installs built with isolation fetched an unpinned setuptools/setuptools_scm. Every
pip install -ein.github/workflowsnow passes--no-build-isolation, using the backend from the hash-lockedci/requirements/bootstrap.txt(#5355).tests/core_engine/test_ci_install_pins.py: removed the strict xfail ontest_workflows_build_without_isolation; it now enforces the rule.tests/tools/test_pr_gates_fleet.py: the mypy-audit assertion still named the removedtests/requirements-mypy.txt(stale since ci: hash-lock the mypy toolchain; local installs use the locked backend (Part of #4918) #5355); now namesci/requirements/mypy.txt.Needs owner review: workflow files are CODEOWNERS-protected. A job that lacks the bootstrap lock install before the editable install would fail; the gate test checks every workflow for this.
Class table
pip install -e(all variants:.,./gitgalaxy,./main, extras)publish.ymlpython -m build(isolated)pip install -r requirements.txt(smoke-test, full-suite-gate, os-smoke-grid), unhashedtests/toolsvenv scripts (crucible_check) localpip install -eNo burned mainframe estate needs any of these. No golden bless (no parsing change).
Gates:
pr_gates --fast6/6,--ratchets8/8,audit_check.pyclear,tests/tools1358 pass. One failure not caused by this change:test_pin_requirements_check_allreportsci/requirements/pytest.txtandtest.txtSTALE (lockfiles untouched here; likely the local pip-compile environment, not re-checked on main).Cross-repo: none.
🤖 Generated with Claude Code