Repository navigation
det: refuse a non-digit in the PERFORM VARYING variable and SET BY target (Part of #4692) - #5404
Merged
Merged
Conversation
…WN BY target (Part of #4692) The step of a PERFORM VARYING variable and SET x UP/DOWN BY read the item before storing it, as the receiver of ADD does, but through plain Cobol.num; they now go through Cobol.receiverNum and are refused by name when a zoned item holds a non-digit (register C11). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
squid-protocol
added
the
shepherd:merge
Owner
Author
|
No description provided. |
squid-protocol
marked this pull request as ready for review
October 18, 2026 03:28
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4692 (follows #4889 receiver, #5327 counters/pointers, #4992/#4996 P-scaled).
What
The step of a
PERFORM VARYINGvariable andSET x UP/DOWN BYread the item before storing it, as the receiver ofADDdoes, but through plainCobol.num. They now useCobol.receiverNum: a zoned item holding a non-digit is refused by name (register C11, IBM documents no result). Digit-only items step as before; theFROMstore overwrites first, so spaces before the loop still translate.Files:
gen.py(2 sites),Cobol.java(javadoc),cobolrt_rules.json(rule title),test_det_nondigit_zoned.py(3 tests).Class and gaps
Class: read-modify-write of a zoned item holding a non-digit. Not changed: the SEARCH implicit index
+1(gen.py ~2156), because the index is not a zoned field. SET BY on a zoned target is changed but has no test (no parseable zoned SET BY found); the code path is the same helper.Burned-estate need:
det_port checklists 19 ports whose generated service changed (the VARYING step), so burned programs do loop over zoned variables; none holds a non-digit in the proved scenarios.Evidence
test_det_nondigit_zoned.py -k "varying or receiver or counter": 115 pass.det_port.py check: 103/122 unchanged, 19 changed;det_port.py runon those 19: 17 PROVED, 2 DIFFERS (cbsa-crecust: oracleCEEDAYS: picture not modelled; cbsa-bnk1ccs: java-facade COMMAREA[BREFUSED). Neither message is a non-digit refusal; Re-run on origin/main (960d83a): both are DIFFERS there too, so pre-existing on main.audit_check.pyall clear,pr_gates.py --fast6/6,test_cobolrt_rules.py51 pass.Cross-repo
None.
🤖 Generated with Claude Code