Repository navigation
crucible: committed det port of PCWIZ drives the byte overload with a COMMAREA RETURN (Part of #4965) - #5325
Merged
Merged
Conversation
…oad with a COMMAREA RETURN (Part of #4965) The model ports RETURN DTO-only, so lastAnswerBytes() is null on them. The det port of pc-wizard (PCWIZ + PCCONF) RETURNs TRANSID with a 30-byte COMMAREA through returnTransid(.., byte[]); the crucible java-facade side passes 6/6 on it, and deleting the facade's assignment fails 6/6. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
squid-protocol
added
the
shepherd:merge
Owner
Author
|
No description provided. |
squid-protocol
marked this pull request as ready for review
October 17, 2026 10:31
squid-protocol
enabled auto-merge (squash)
October 17, 2026 10:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4965. Closes the owner's remaining bullet: a committed scenario that RETURNs TRANSID with a COMMAREA through
handleTransaction(.., byte[]).What changed
tests/cics_crucible/det-ports/pc-wizard/PCWIZ/overlay/service/: the deterministic port of PCWIZ and PCCONF (39/39 and 47/47 statements, no holes). Kept out ofports/so port records stay model-only (no provenance).tests/tools/cics_crucible_det.py:ports_dir(committed services + runtime, for--ports) andbuild(regenerate).tests/cics_crucible/test_det_port_bytes_4965.py: 3 cheap structural tests, plus anEQUIVALENCE_E2E=1test (slow-marked) that runs java-facade on the port and on the mutant.docs/language_status/mutation_testing.md: small appended paragraph.Evidence (measured 2026-10-17)
lastAnswerBytes()(RETURN TRANSID PC02/PC03, 30-byte COMMAREA), page-aware (#5061)lastAnswerBytes = task.returnedBytes();deletedClass sweep
Class: harness never exercises the byte-carrying path because committed crucible ports RETURN DTO-only.
returnImmediate(.., byte[]), PCIMM*)handleLink)java-ported+java-facade) in one--keeprun with--portsFileExistsErrorin the shared work dir (run them as separate invocations)Cross-repo
None. cics-crucible pin unchanged; no engine, golden or ledger change.
Gates:
pr_gates --fast6/6,--ratchets8/8, ruff/mypy audits clean.🤖 Generated with Claude Code