WCCP: Fix offset calculation when parsing incoming packets - #2484
Open
squidadm wants to merge 1 commit into
Open
WCCP: Fix offset calculation when parsing incoming packets#2484squidadm wants to merge 1 commit into
squidadm wants to merge 1 commit into
Conversation
…he#2480) Since 2021 commit 464223c, WCCPv2 packet parsing code was using wrong offsets due to a `CheckFieldDataLength()` bug: * `wccp2_item_header_t` and `wccp2_capability_info_header_t`: The function returned a wrong offset on any 64-bit build, shifting dataStart and the returned field size by 4 bytes and desynchronizing the parse of subsequent WCCPv2 packet items; * `wccp2_capability_element_t`: The function happened to return a correct offset only on platforms with 8-byte pointers. This change is a reference point for automated CONTRIBUTORS updates.
squid-anubis
added
the
M-failed-description
Collaborator
|
Cannot create a git commit message from PR title and description. Error while parsing future commit message title: Problematic parser input: Please see PR title and description formatting requirements for more details. This message was added by Anubis bot. Anubis will add a new message if the error text changes. Anubis will remove M-failed-description label when there are no corresponding failures to report. |
kinkie
changed the title
squid-anubis
removed
the
M-failed-description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 2021 commit 464223c, WCCPv2 packet parsing code was using
wrong offsets due to a
CheckFieldDataLength()bug:wccp2_item_header_tandwccp2_capability_info_header_t: Thefunction returned a wrong offset on any 64-bit build, shifting
dataStart and the returned field size by 4 bytes and desynchronizing
the parse of subsequent WCCPv2 packet items;
wccp2_capability_element_t: The function happened to return acorrect offset only on platforms with 8-byte pointers.
This change is a reference point for automated CONTRIBUTORS updates.