Maintenance: Add missing stub_fde.cc#2359
Open
yadij wants to merge 3 commits intosquid-cache:masterfrom
Open
Conversation
rousskov
approved these changes
Jan 27, 2026
Contributor
rousskov
left a comment
rousskov
left a comment
There was a problem hiding this comment.
I added PR description to discuss fdNFree() changes.
rousskov
added
S-waiting-for-author
squid-anubis
pushed a commit
that referenced
this pull request
Jan 27, 2026
Also moved `fdNFree()` declaration to `fd.h` (to match its definition location) and polished its stub's return value.
squid-anubis
added
M-waiting-staging-checks
yadij
added
M-cleared-for-merge
squid-anubis
added
the
M-abandoned-staging-checks
yadij
removed
M-failed-staging-checks
squid-anubis
pushed a commit
that referenced
this pull request
Jan 31, 2026
Also moved `fdNFree()` declaration to `fd.h` (to match its definition location) and polished its stub's return value.
squid-anubis
added
M-waiting-staging-checks
kinkie
removed
M-failed-staging-checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also moved
fdNFree()declaration tofd.h(to match its definitionlocation) and polished its stub's return value.