Polish SQUID_CHECK_KRB5_CONTEXT_MEMORY_KEYTAB macro#2317
Open
yadij wants to merge 2 commits intosquid-cache:masterfrom
Open
Polish SQUID_CHECK_KRB5_CONTEXT_MEMORY_KEYTAB macro#2317yadij wants to merge 2 commits intosquid-cache:masterfrom
yadij wants to merge 2 commits intosquid-cache:masterfrom
Conversation
Contributor
yadij
commented
Dec 10, 2025
- trivial whitespace cleanup
- reposition for alphabetical naming order
- move SQUID_DEFINE_BOOL inside the check macro
Contributor
Author
|
FTR; these changes have already passed review in PR #1157. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
rousskov
requested changes
Dec 21, 2025
This comment was marked as resolved.
This comment was marked as resolved.
kinkie
previously approved these changes
Dec 25, 2025
This comment was marked as resolved.
This comment was marked as resolved.
kinkie
previously approved these changes
Dec 30, 2025
22b9ec9 to
5909c80
Compare
kinkie
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.