Repository navigation
ci(oracle) :: install Instant Client 23ai from ZIPs instead of converted RPMs - #1525
Merged
Merged
Conversation
…ted RPMs Replace the RPM-to-Debian conversion (alien) with Oracle's official 23ai ZIPs, extracted to a private directory with a private odbcinst.ini. This also moves the test client from 21c, an older innovation release, to 23ai (23.26.0.0.0), matching the database server used in CI. Verified locally: all 90 integration tests pass in ~16s with this client against Oracle 23.26.2, with a clean process exit.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the RPM-to-Debian conversion (
alien) in the Oracle CI job with Oracle's official Instant Client ZIPs, extracted to a private directory with a privateodbcinst.ini(same approach as the DuckDB installer script). This also moves the test client from 21c, an older innovation release, to 23ai (23.26.0.0.0), matching the database server used in CI (gvenzl/oracle-free:23.x).The installer is parameterized (
oracle_version/oracle_build/oracle_dir/oracle_driver/oracle_so) and sha256-verifies the archives even on cache hits.Validation (local): installed the client via the new script, ran the full suite as CI does against Oracle 23.26.2: 90 passed, 0 failed in ~16s, clean process exit.
Note: no public reports of the
finiSqora/bccFreeProcessexit hang were found during the investigation (bccFreeProcesshas zero web hits;finiSqoraappears only in an unrelated 2020 crash stack).