fix(comparison): make decision tolerance adaptive to observed page jitter#6064
Open
ebrasha wants to merge 1 commit into
Open
fix(comparison): make decision tolerance adaptive to observed page jitter#6064ebrasha wants to merge 1 commit into
ebrasha wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The final decision in
_comparison()used a hard-codedDIFF_TOLERANCE = 0.05.On dynamic targets, normal page noise (rotating banners, timestamps, ad slots, slight markup drift) easily crosses that 5% line and gets read as a real True/False signal.
To fix this, I made the tolerance adaptive:
kb.matchRatiogets locked, I also compute jitter using MAD (Median Absolute Deviation) over the same calibration bufferkb.matchRatioJittertolerance = max(DIFF_TOLERANCE, JITTER_TOLERANCE_MULTIPLIER * jitter)The static
DIFF_TOLERANCEstill acts as a hard floor — pages that are actually stable behave exactly like before.Why this is better
5% was a reasonable default 10 years ago, but on modern dynamic pages it's just too tight. We were paying the cost in false positives.
Scope
lib/request/comparison.py