Fix false positives in large-response comparison fallback#6062
Open
ebrasha wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR fixes a false-positive issue in SQLi detection when response comparison falls back for very large pages (or when
SequenceMatcheris skipped).Previously, in that fallback path we only compared response lengths.
That meant two completely different large responses with similar sizes could produce a high ratio and be treated as similar, which could lead to incorrect injection signals.
The fallback now uses lightweight sampled content similarity instead of raw length-only comparison:
Why this is better
Scope
Only
lib/request/comparison.pyis updated.No behavioral change intended outside the large-response/skip-seqmatcher fallback branch.