Fix Query.Clone() shallow copy of Includes and Variables#775
Merged
ahmad-moussawi merged 2 commits intomainfrom Apr 10, 2026
Merged
Fix Query.Clone() shallow copy of Includes and Variables#775ahmad-moussawi merged 2 commits intomainfrom
ahmad-moussawi merged 2 commits intomainfrom
Conversation
- Add Clone() method to Include class for deep copying - Fix Query.Clone() to deep-copy Includes list and Variables dictionary - Fix XQuery.Clone() with same deep-copy fixes - Add unit tests for the clone bug (independent list, objects, dict, properties) Fixes #747 Agent-Logs-Url: https://github.com/sqlkata/querybuilder/sessions/d82ad628-73f5-4c2f-b56e-f4021ce1519f Co-authored-by: ahmad-moussawi <2517523+ahmad-moussawi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bug in Query.Clone() to ensure independent copies
Fix Query.Clone() shallow copy of Includes and Variables
Apr 10, 2026
ahmad-moussawi
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query.Clone()andXQuery.Clone()assignedIncludesandVariablesby reference, so mutations on the clone leaked back to the original.Changes
Include: AddedClone()method that deep-copies all fields, including recursively cloning the embeddedQuery.Query.Clone(): Replace reference assignments withIncludes.Select(i => i.Clone()).ToList()andnew Dictionary<string, object>(Variables).XQuery.Clone(): Same fixes applied for consistency.Original prompt
This pull request was created from Copilot chat.