fix: reject LLM calls with incompatible contexts - #34
Open
mikemikimike wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / Problem
Closes #33.
llm_text_generate()andllm_embed_generate()only checked whether a context existed, so calling one with the other operation's context could silently return an empty result or run against incompatible state.Changes
SQLITE_MISUSEwith an actionable error.Tests
git diff --check— passed.Compatibility / Known limitations
Valid calls retain their existing behavior. This changes an invalid context/operation combination from a silent result to an explicit
SQLITE_MISUSEerror. The full model-backed test suite remains to be run in an environment with the repository's native toolchain and test model dependencies.