fix: correct typos in sqlite catalog function names and comments#4507
Open
maxtaran2010 wants to merge 1 commit into
Open
fix: correct typos in sqlite catalog function names and comments#4507maxtaran2010 wants to merge 1 commit into
maxtaran2010 wants to merge 1 commit into
Conversation
- RAMDOM → RANDOM and RAMDOMBLOB → RANDOMBLOB in sqlite/stdlib.go: these misspellings caused sqlc to not recognize SQLite's RANDOM() and RANDOMBLOB() built-in functions in queries - prepand → prepend in codegen/golang/struct.go (comment) - unsiged → unsigned in codegen/golang/opts/override.go (comment) - simpliest → simplest in compiler/selector.go (comment) - Overides → Overrides in protos/plugin/codegen.proto (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix several typos found across the codebase:
internal/engine/sqlite/stdlib.go(functional bug):RAMDOM→RANDOMandRAMDOMBLOB→RANDOMBLOB. These misspellings in the SQLite built-in function catalog mean sqlc fails to recognizeRANDOM()andRANDOMBLOB()in queries.internal/codegen/golang/struct.go:prepand→prependin commentinternal/codegen/golang/opts/override.go:unsiged→unsignedin commentinternal/compiler/selector.go:simpliest→simplestin commentprotos/plugin/codegen.proto:Overides→Overridesin commentThe
RANDOM/RANDOMBLOBfix is the most impactful — it's a functional issue where queries using SQLite's built-in random number functions won't be recognized by sqlc.