Add EXPLAIN AST support for ALTER, OPTIMIZE, and TRUNCATE queries #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add three new explain functions to properly format: - AlterQuery with all ALTER command types (ADD/DROP/MODIFY COLUMN, RENAME COLUMN, indexes, constraints, TTL, settings, partitions, etc.) - OptimizeQuery with FINAL suffix handling - TruncateQuery with database.table format This enables 182+ previously failing explain tests to pass by properly outputting the AST format expected by ClickHouse's EXPLAIN AST.
Remove explain_todo entries for tests that now pass after adding EXPLAIN AST support for ALTER, OPTIMIZE, and TRUNCATE queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add three new explain functions to properly format:
RENAME COLUMN, indexes, constraints, TTL, settings, partitions, etc.)
This enables 182+ previously failing explain tests to pass by properly
outputting the AST format expected by ClickHouse's EXPLAIN AST.