Support identifiers starting with digits in lexer #70
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClickHouse allows identifiers like '1alias1name1' as aliases after AS. The lexer now recognizes these as identifiers rather than treating the leading digits as a NUMBER token followed by an IDENT token. The change adds a check in readNumberOrIdent to detect when digits are directly followed by letters (excluding exponent notation like 1e5 and base prefixes like 0x, 0b, 0o).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClickHouse allows identifiers like '1alias1name1' as aliases after AS.
The lexer now recognizes these as identifiers rather than treating the
leading digits as a NUMBER token followed by an IDENT token.
The change adds a check in readNumberOrIdent to detect when digits are
directly followed by letters (excluding exponent notation like 1e5 and
base prefixes like 0x, 0b, 0o).