Skip to content

fix: make Database.each return the database object for chaining #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cpruijsen wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

fix: make Database.each return the database object for chaining #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,9 +1035,9 @@ Module["onRuntimeInitialized"] = function onRuntimeInitialized() {
stmt.free();
}
if (typeof done === "function") {
return done();
done();
}
return undefined;
return this;
};

/** Prepare an SQL statement
Expand Down
2 changes: 2 additions & 0 deletions test/test_database.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ exports.test = function(SQL, assert, done) {
// Testing db.each
db.run("CREATE TABLE test (a,b); INSERT INTO test VALUES (1,'a'),(2,'b')");
var count = 0, finished = false;
var chained = db.each("SELECT * FROM test", function () {}, function () {});
assert.strictEqual(chained, db, "db.each returns the database object");
db.each("SELECT * FROM test ORDER BY a", function callback (row){
count++;
if (count === 1) assert.deepEqual(row, {a:1,b:'a'}, 'db.each returns the correct 1st row');
Expand Down