fix: handle 24:00:00 time string from GivEnergy Cloud#3652
Merged
springfall2008 merged 1 commit intomainfrom Mar 25, 2026
Merged
fix: handle 24:00:00 time string from GivEnergy Cloud#3652springfall2008 merged 1 commit intomainfrom
springfall2008 merged 1 commit intomainfrom
Conversation
GivEnergy Cloud returns "24:00:00" for discharge_end_time (meaning midnight/end of day). This is valid ISO 8601 but crashes strptime. Normalise to "00:00:00" before parsing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time_string_to_stamp()crash when GivEnergy Cloud returns24:00:00for discharge end time24:xx:xxto00:xx:xxbeforestrptimeparsingTest plan
time_string_to_stamp("24:00:00")returnsdatetime(1900, 1, 1, 0, 0)