Repository navigation
fix: make the deprecated annotations registry thread safe - #3402
Open
awinishere wants to merge 1 commit into
Open
awinishere wants to merge 1 commit into
awinishere wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEPRECATED_ANNOTATIONSis asynchronizedList, butisDeprecated(..)streams it without holdingthe lock
synchronizedListonly synchronizes single calls. A type registered by one thread whileanother generates the documentation throws
ConcurrentModificationException: the 500 on/v3/api-docsin the report. Same field also grows without bound, sinceSpringDocKotlinConfigurationregisters
Deprecated::class.javaon every context start.Made the registry a
CopyOnWriteArraySetthe fix suggested in the issue, all usagesadd,contains,streamareSetoperations, so nothing else changed.Running the reported scenario as is context start as writer,
isDeprecatedas reader, JDK 21report is on JDK 26:
2is correct:java.lang.Deprecatedandkotlin.Deprecatedare distinct types, only duplicates go.Added
SchemaPropertyDeprecatingConverterTest3 tests. Two of them fail on the previous code withexpected: <1> but was: <101>andexpected: <null> but was: ConcurrentModificationException; thethird asserts
@Deprecatedis still detected and passes on both. Full reactor: 25 modules, 1850 tests,0 failures.
Fixes #3400