Skip to content

fix: skip url param when urls already populated to fix BaseLayout + GroupedOpenApi break (fixes #3243) #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
souravCoder1 wants to merge 1 commit into from
Closed

fix: skip url param when urls already populated to fix BaseLayout + GroupedOpenApi break (fixes #3243) #3249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...starter-common/src/main/java/org/springdoc/core/properties/SwaggerUiConfigParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@

import org.apache.commons.lang3.StringUtils;

import org.springdoc.core.utils.SpringDocPropertiesUtils;
Copy link
Contributor

@Mattias-Sehlstedt Mattias-Sehlstedt Mar 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import should not be necessary given that the full path is used still (or it might be nicer to have the import and remove the full path?)

Copy link
Author

@souravCoder1 souravCoder1 Mar 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, we can remove

import org.springframework.util.CollectionUtils;

import static org.springframework.util.AntPathMatcher.DEFAULT_PATH_SEPARATOR;
Expand Down Expand Up @@ -289,7 +290,8 @@ public Map<String, Object> getConfigParameters() {
if (supportedSubmitMethods != null)
org.springdoc.core.utils.SpringDocPropertiesUtils.put("supportedSubmitMethods", supportedSubmitMethods, params);
org.springdoc.core.utils.SpringDocPropertiesUtils.put(OAUTH2_REDIRECT_URL_PROPERTY, oauth2RedirectUrl, params);
org.springdoc.core.utils.SpringDocPropertiesUtils.put(URL_PROPERTY, url, params);
if (CollectionUtils.isEmpty(urls))
org.springdoc.core.utils.SpringDocPropertiesUtils.put(URL_PROPERTY, url, params);
put(URLS_PROPERTY, urls, params);
org.springdoc.core.utils.SpringDocPropertiesUtils.put("urls.primaryName", urlsPrimaryName, params);
org.springdoc.core.utils.SpringDocPropertiesUtils.put(TRY_IT_ENABLED_PROPERTY, tryItOutEnabled, params);
Expand Down
Loading