Prevent circular ACL parent relationships - #19557
Open
yashdotdev13 wants to merge 1 commit into
Open
Conversation
Signed-off-by: 98001yash <yashchauhan.gaya@gmail.com>
yashdotdev13
force-pushed
the
fix/19513-acl-parent-cycle
branch
from
August 17, 2026 21:58
91de514 to
67b8b20
Compare
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19513
This change prevents circular parent relationships from being created
when configuring ACL hierarchies.
Previously,
AclImpl#setParentonly prevented an ACL from beingassigned itself as its parent. This allowed indirect circular
relationships to be created.
The implementation now walks the existing parent hierarchy and rejects
a relationship when the current ACL instance is encountered.
Tests were added for both direct and indirect circular parent
relationships.
Existing parent-changing behavior is also covered by the existing test
suite.
Tests:
./gradlew :spring-security-acl:test