Allow custom AuthenticationConverter in WebAuthnAuthenticationFilter#19412
Open
therepanic wants to merge 1 commit into
Open
Allow custom AuthenticationConverter in WebAuthnAuthenticationFilter#19412therepanic wants to merge 1 commit into
therepanic wants to merge 1 commit into
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
This change allows us to delegate the `attemptAuthentication` logic to the `AuthenticationConverter` interface and enables the definition of custom instances. Additionally, we have added a default implementation, `WebAuthnAuthenticationConverter`, whose behavior is fully deterministic with respect to the previous implementation. Closes: spring-projectsgh-19411 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
commented
Jul 2, 2026
Comment on lines
120
to
+134
| @@ -144,6 +131,21 @@ public void setConverter(GenericHttpMessageConverter<Object> converter) { | |||
| public void setConverter(SmartHttpMessageConverter<Object> converter) { | |||
| Assert.notNull(converter, "converter cannot be null"); | |||
| this.converter = converter; | |||
| this.webAuthnAuthenticationConverter.setConverter(converter); | |||
Contributor
Author
There was a problem hiding this comment.
Perhaps this behavior should be better documented?
Contributor
Author
|
Does anyone have any ideas on the best place in the documentation to put information about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows us to delegate the
attemptAuthenticationlogic to theAuthenticationConverterinterface and enables the definition of custom instances. Additionally, we have added a default implementation,WebAuthnAuthenticationConverter, whose behavior is fully deterministic with respect to the previous implementation.Closes: gh-19411