7:28Add debug logging for parent AuthenticationManager#19189
Open
jankavka wants to merge 1 commit into
Open
Conversation
When a parent AuthenticationManager fails with an AuthenticationException, the exception is currently caught and stored silently, making it difficult to diagnose authentication failures that originate in the parent manager at runtime. Add a debug log message consistent with the existing logging throughout the authenticate method to aid debugging. The affected code path is already covered by existing tests in ProviderManagerTests. Signed-off-by: jankavka <jankavka@seznam.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a parent AuthenticationManager fails with an
AuthenticationException, the exception is currently caught and stored silently, making it difficult to diagnose authentication failures that originate in the parent manager at runtime.
Add a debug log message consistent with the existing logging throughout the authenticate method to aid
debugging.
The affected code path is already covered by existing tests in ProviderManagerTests.