Fix deserializer for AuthenticationExtensionsClientOutputs#18644
Fix deserializer for AuthenticationExtensionsClientOutputs#18644ziqin wants to merge 3 commits intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
| } | ||
|
|
||
| @Test | ||
| void readAuthenticationExtensionsClientOutputsWhenUnknownExtension() throws Exception { |
There was a problem hiding this comment.
Since it appears that this would pass without your changes, will you please place this in an earlier commit to confirm that your changes don't alter this behavior?
There was a problem hiding this comment.
This test is also intended for identifing the deserialization bug.
According to the results on my machine, it also fails without the fix.
| } | ||
|
|
||
| @Test | ||
| void readAuthenticationExtensionsClientOutputsWhenUnknownExtension() { |
There was a problem hiding this comment.
Since it appears that this would pass without your changes, will you please place this in an earlier commit to confirm that your changes don't alter this behavior?
There was a problem hiding this comment.
This test is also intended for identifing the deserialization bug.
According to the results on my machine, it also fails without the fix.
jzheaux
added
type: bug
jzheaux
added
the
status: waiting-for-feedback
Signed-off-by: Ziqin Wang <ziqin@wangziqin.net>
Signed-off-by: Ziqin Wang <ziqin@wangziqin.net>
The deserializer is updated to properly ignore unknown extensions. This fix addresses the WebAuthn authentication failure appeared when using FIDO2 security keys on Safari. Closes spring-projectsgh-18643 Signed-off-by: Ziqin Wang <ziqin@wangziqin.net>
|
Hi, @jzheaux I have rebased this PR on 7.0.x. The two tests are now placed on earlier commits and the GitHub issue is now mentioned in the fixing commit message. Thanks for your review. |
|
I believe that this fix should also be backported to 6.5.x because the deserilization bug also exists there, although it may not cause an immediate WebAuthn authentication failure. |
spring-projects-issues
added
status: feedback-provided
3 participants
The deserializer is updated to properly ignore unknown extensions.
This PR fixes gh-18643.