GH-1849 Fix WorkingDirectoryChangesDetector for git submodule work trees - #1850
Open
lindsaythurmond wants to merge 1 commit into
Open
Conversation
…bmodule work trees. Use the Git work tree instead of the git directory parent when resolving the repository-relative working directory. Add tests for submodule layouts and extract path computation for unit testing. Signed-off-by: Lindsay Thurmond <lindsay.thurmond@gmail.com>
lindsaythurmond
force-pushed
the
fix-working-directory-detector-git-submodules
branch
from
September 1, 2026 21:03
7443916 to
d3efc89
Compare
lindsaythurmond
changed the title
WorkingDirectoryChangesDetector for git submodule work trees
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1849
Summary
WorkingDirectoryChangesDetector.of()resolves the repository root viarepository.getDirectory().getParent(). In a git submodule checkout,.gitis agitdir:pointer into the parent repository's.git/modules/...directory, so that path points at git metadata rather than the submodule work tree.When JUnit tests run from a nested Maven module inside such a work tree, computing the repository-relative working directory can throw
StringIndexOutOfBoundsExceptionduringModulithExecutionConditionevaluation — before any application tests execute.Fix
Use
repository.getWorkTree().getAbsolutePath()as the repository root, which is correct for standard repositories and submodule work trees alike.Path computation is extracted into
repositoryRelativeWorkingDirectory(...)so it can be unit-tested directly (without relying on JVM working-directory changes under Surefire).Tests