Skip to content

Apply keepalive settings only when enableKeepAlive is true#384

Closed
therepanic wants to merge 1 commit intospring-projects:mainfrom
therepanic:gh-383
Closed

Apply keepalive settings only when enableKeepAlive is true#384
therepanic wants to merge 1 commit intospring-projects:mainfrom
therepanic:gh-383

Conversation

@therepanic
Copy link
Copy Markdown
Contributor

@therepanic therepanic commented Mar 5, 2026

This commit fixes an issue where we were applying keep-alive settings even when we had disabled the feature.

Closes: spring-projects/spring-boot#49829

@therepanic therepanic changed the title Apply keepalive settings only when enableKeepAlive is true Apply keepalive settings only when enableKeepAlive is true Mar 5, 2026
This commit fixes an issue where we were applying keep-alive settings
even when we had disabled the feature.

Closes: gh-383

Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
@therepanic therepanic marked this pull request as ready for review March 5, 2026 18:51
@dsyer dsyer added the status: post-spring-boot-migration Must wait until after #234 is complete label Mar 19, 2026
@philwebb
Copy link
Copy Markdown
Member

Thanks @therepanic, but I'm going to close this one due to the code moving to Spring Boot and spring-projects/spring-boot#49829 (comment)

@philwebb philwebb closed this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: post-spring-boot-migration Must wait until after #234 is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spring.grpc.client.default-channel.enable-keep-alive has no effect

3 participants