Avoid redundant filtering in FilteredMap.size() - #37256
Open
noojung wants to merge 1 commit into
Open
Conversation
Since keySet() already applies the filter, size() evaluated the predicate twice for every accepted key. This commit uses delegate.keySet() instead, avoiding the second evaluation as well as a FilteredSet and FilteredIterator allocation. Signed-off-by: Hyunwoo Jung <hyunwoojung@kakao.com>
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
added
the
in: core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FilteredMap.size()iterates overkeySet(), which already applies the predicate through aFilteredSetwrapper.The loop then tests each accepted key a second time.
This PR updates
FilteredMap.size()to iterate overdelegate.keySet()instead, avoiding redundant evaluations and the creation of aFilteredSetwrapper on every call.