Skip to content

Fix missing assertion in DefaultClientResponseTests - #37248

Closed
noojung wants to merge 1 commit into
spring-projects:mainfrom
noojung:task/default-client-response-tests
Closed

Fix missing assertion in DefaultClientResponseTests#37248
noojung wants to merge 1 commit into
spring-projects:mainfrom
noojung:task/default-client-response-tests

Conversation

@noojung

@noojung noojung commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Add the missing .isTrue() to the header assertion in createError().

Also remove obsolete deprecation suppressions from createError() and createException().

Signed-off-by: Hyunwoo Jung <hyunwoojung@kakao.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 7, 2026
@sbrannen sbrannen self-assigned this Sep 7, 2026
@sbrannen sbrannen added type: task A general task in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 7, 2026
@sbrannen sbrannen added this to the 7.0.10 milestone Sep 7, 2026
@sbrannen
sbrannen changed the base branch from main to 7.0.x September 7, 2026 08:13
@sbrannen
sbrannen changed the base branch from 7.0.x to main September 7, 2026 08:14
sbrannen pushed a commit that referenced this pull request Sep 7, 2026
Closes gh-37248

Signed-off-by: Hyunwoo Jung <hyunwoojung@kakao.com>
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Fixed via 4acd6d6

@github-actions github-actions Bot closed this Sep 7, 2026
@sbrannen

sbrannen commented Sep 7, 2026

Copy link
Copy Markdown
Member

This has been merged into 7.0.x and main.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants