Add option to parse named parameters in SQL comments - #37088
Open
benelog wants to merge 1 commit into
Open
Conversation
By default, named parameters within SQL comments are ignored. Some database engines interpret hints or routing keys declared in comments, for example "/*@ queryKey(:userId) */ SELECT ...", requiring such parameters to be substituted and bound as well. This commit introduces a parseSqlStatement variant with an allowParametersInComments flag in NamedParameterUtils as well as a corresponding allowParametersInComments property on NamedParameterJdbcTemplate. Closes spring-projectsgh-22255 Signed-off-by: Sanghyuk Jung <sanghyuk.jung@navercorp.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces:
NamedParameterUtils.parseSqlStatement(String, boolean)with anallowParametersInCommentsflagallowParametersInCommentsproperty onNamedParameterJdbcTemplate(defaultfalse, preserving the current behavior)Even with the flag enabled, string literals and quoted identifiers are still skipped. Changing the flag resets the template's parsed SQL cache, so previously parsed statements are re-parsed with the new setting.
Closes gh-22255