Use HttpHeaders.copyOf in DefaultClientResponseBuilder - #37087
Open
yashmehla wants to merge 1 commit into
Open
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: yashmehla <mehlayash@icloud.com>
yashmehla
force-pushed
the
fix-37086-clientresponse-mutate
branch
from
July 25, 2026 07:33
ddf74e5 to
4aa76f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37086.
ClientResponse.mutate()currently modifies the original response's headers becauseDefaultClientResponseBuilderinitializes its headers using theHttpHeaders(HttpHeaders)constructor, which shares the underlying headers.This change uses
HttpHeaders.copyOf(...)so that the builder works with an independent copy of the original response's headers.A regression test has been added to verify that mutating the builder does not modify the original response's headers or cookies.