Skip to content

Document WebFlux RequestContext locale change scope#36880

Draft
king-407 wants to merge 1 commit into
spring-projects:mainfrom
king-407:issue-36738-webflux-requestcontext-javadoc
Draft

Document WebFlux RequestContext locale change scope#36880
king-407 wants to merge 1 commit into
spring-projects:mainfrom
king-407:issue-36738-webflux-requestcontext-javadoc

Conversation

@king-407

@king-407 king-407 commented Jun 7, 2026

Copy link
Copy Markdown

This PR updates the WebFlux RequestContext Javadoc for both changeLocale(...) overloads.

Unlike the Spring MVC RequestContext, the WebFlux implementation only updates the current RequestContext instance. It does not persist the locale or locale/time-zone change through LocaleContextResolver.

The added Javadoc clarifies that the change is scoped to the current rendering operation and adds related @see references.

Closes gh-36738

@king-407 king-407 marked this pull request as draft June 7, 2026 21:26
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 7, 2026
Signed-off-by: king-407 <95581750+king-407@users.noreply.github.com>
@king-407 king-407 force-pushed the issue-36738-webflux-requestcontext-javadoc branch from 1fb99bb to e8d6484 Compare June 7, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-triage An issue we've not yet triaged or decided on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebFlux RequestContext.changeLocale() lacks Javadoc for rendering-scope limitation (MVC parity gap)

2 participants