Skip to content

Make message decoding in ProtobufDecoder more extensible #37265

Description

@dsyer

Recent changes in ProtobufDecoder have made it more open to extension. One thing that is missing still is the ability to override the Message creation step. The base class does all the interesting stuff, and comes up with a byte buffer with the message contents, but then doesn't allow you to insert your own logic for decoding. A protected method in ProtobufDecoder would be great, or a helper interface like MessageSizeReader.

Would enable us to more easily (without copy-pasting the whole of ProtobufDecoder) support grpc-web in spring-projects/spring-grpc#427.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions