Switch to ubuntu-resolute-builder as the default builder - #51249
anthonydahanne wants to merge 2 commits into
Conversation
f812f8d to
f32c716
Compare
22f22d9 to
95f9f67
Compare
|
This is great! Does it also solve #51166? |
ah! I just looked at it, and yes, I guess setting the So yes, this PR should solve that issue too |
|
Hello @anthonydahanne, thanks for the PR! Just for my understanding: |
4c78468 to
4b7bbf3
Compare
|
Hello @mhalbritter , sorry for late answer, working on my github filters 🫠 ... So,
yes
yes
yes
Yeah, what changed really is that we have less builders than before, and rely more on WRT How it works:
<configuration>
<image>
<runImage>paketobuildpacks/ubuntu-resolute-run</runImage>
</image>
</configuration>It also relies on your recent change that turned the stack-id mismatch into a warning rather than an error : This should also close #51166. |
4b7bbf3 to
bb3695d
Compare
…lder * replacing Noble * not addressing the spring-boot-cnb-test-builder still based on Noble yet; it could wait for this PR to be merged first. Signed-off-by: Anthony Dahanne <anthony.dahanne@gmail.com>
…lder * Add support for native image builds with Buildpacks * Introduced compatibility checks for Stack IDs. * Configured default tiny run image for native builds (`BP_NATIVE_IMAGE=true`). * Enabled Gradle and Maven plugins to set `BP_NATIVE_IMAGE` environment variable during build image tasks. Signed-off-by: Anthony Dahanne <anthony.dahanne@gmail.com>
bb3695d to
8cfd036
Compare
|
I'm thinking about to switch the run image unconditionally to the shell-less variant (as we have now), and if users want to have a shell, they can opt in by changing the run image. This would preserve the same behavior as we have today, and we could drop the changes for the native image case. Only downside is that we get a warning every build about non-matching stack ids (the same warning pack gives): Ours: pack's: The fix for the warning, if we want to diverge from pack behavior: #51166 asked for it (long term solution): skip it when Let me talk to the team about that. |
|
I consider our alignment with Having thought about this some more, I don't think the current warnings (either ours or pack's) are particularly helpful as there are situations where the user can't really do anything to fix it. I think it makes sense to change things so that this fairly common scenario is warning free. |
Hello Spring friends 👋
This is a candidate PR to upgrade Spring Boot to using the latest Ubuntu LTS: Resolute.
I think it's in a good shape, and would represent progress to Spring users.
Now, I understand you probably don't want to change the builder during a random patch release; so I suggest we let this PR open, and you target it to the proper versions, and on my side I'll keep it up to date against
mainAlso, if you're open to contributions for upgrading
spring-io/spring-boot-cnb-test-builderto Resolute too, I'd be happy to, just tell me and I PR that.Happy reviewing 📖 ☕ !