Add clean-history-on-start and total-size-cap rolling policy properties for Log4J2 - #51153
Open
elephant-y wants to merge 2 commits into
Open
Add clean-history-on-start and total-size-cap rolling policy properties for Log4J2#51153elephant-y wants to merge 2 commits into
elephant-y wants to merge 2 commits into
Conversation
…es for Log4j2 Add CLEAN_HISTORY_ON_START and TOTAL_SIZE_CAP to Log4j2's RollingPolicySystemProperty enum so that log4j2 users can configure these rolling policy settings via application properties, matching the existing support in logback's RollingPolicySystemProperty. See spring-projectsgh-46468 Signed-off-by: yangzhice <a13644015167@qq.com>
elephant-y
force-pushed
the
gh-46468-log4j2-rolling-policy
branch
from
July 29, 2026 14:34
7e1fd78 to
688f494
Compare
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
changed the title
Member
|
Thanks for the PR but those should be tested if possible. Look at |
snicoll
added
the
status: waiting-for-feedback
snicoll
changed the title
See spring-projectsgh-46468 Signed-off-by: yangzhice <a13644015167@qq.com>
Author
Thanks for the review! I've added assertions for both CLEAN_HISTORY_ON_START and TOTAL_SIZE_CAP to the rollingPolicySystemPropertiesAreApplied test in Log4J2LoggingSystemTests. I also aligned CLEAN_HISTORY_ON_START to use String type (matching logback's approach) since the system property value is resolved as a string. Let me know if there's anything else to address. |
spring-projects-issues
added
status: feedback-provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.