Skip to content

Upgrade to NullAway 0.13.6#50701

Draft
msridhar wants to merge 1 commit into
spring-projects:mainfrom
msridhar:nullaway-0.13.6
Draft

Upgrade to NullAway 0.13.6#50701
msridhar wants to merge 1 commit into
spring-projects:mainfrom
msridhar:nullaway-0.13.6

Conversation

@msridhar

@msridhar msridhar commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

These changes addresses new warnings that arise when updating to NullAway 0.13.6. The PR does not update the NullAway version itself. I'm putting up these changes as a draft as they may be helpful when the maintainers decide to update the NullAway version.

Signed-off-by: Manu Sridharan <msridhar@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 5, 2026
@msridhar

msridhar commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Note that CI will only pass on this one once NullAway is updated to 0.13.6

@philwebb philwebb changed the title Address new warnings from NullAway 0.13.6 Upgrade to NullAway 0.13.6 Jun 10, 2026
@philwebb philwebb added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 10, 2026
@philwebb philwebb added this to the 4.0.x milestone Jun 10, 2026
return getCache().getSystemEnvironmentProperty(name);
}

@SuppressWarnings("NullAway") // https://github.com/uber/NullAway/issues/1578

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be obsolete as soon as uber/NullAway#1597 is part of a release.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we'll try to get that out in a release soon; may be best to wait for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: dependency-upgrade A dependency upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants