Incorrect default value for management.httpexchanges.recording.include in configuration metadata#50010
Merged
snicoll merged 1 commit intospring-projects:3.5.xfrom Apr 10, 2026
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
MohammedGhallab
force-pushed
the
fix-issue-49952
branch
from
ff9fbf9 to
6a3f924
Compare
snicoll
requested changes
Apr 10, 2026
Member
snicoll
left a comment
snicoll
left a comment
There was a problem hiding this comment.
Thanks for the PR. I've added a number of comments for your consideration.
| { | ||
| "name": "management.httpexchanges.recording.include", | ||
| "type": "java.util.Set<org.springframework.boot.actuate.web.exchanges.Include>", | ||
| "description": "Items to include in the exchange recording.", |
Member
There was a problem hiding this comment.
These are unrelated to fixing the incorrect default value, please revert.
| "request-headers", | ||
| "response-headers", | ||
| "errors" | ||
| "time-taken" |
Member
There was a problem hiding this comment.
The default includes are as follows:
As such time-taken should be the first value, not the last.
| } | ||
| ] | ||
| } | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
Re-reading your commit once you've submitted your PR helps to spot those changes you probably didn't mean to do. In this case, the newline has been removed and should be restored.
Contributor
Author
There was a problem hiding this comment.
I have updated the branch with the requested changes. I've reordered the values, removed the unrelated modifications, and ensured the newline at the end of the file is present.
Thank you for the review!
snicoll
added
the
status: waiting-for-feedback
MohammedGhallab
force-pushed
the
fix-issue-49952
branch
from
522f961 to
c79012f
Compare
snicoll
force-pushed
the
fix-issue-49952
branch
from
c79012f to
10de67c
Compare
snicoll
pushed a commit
to MohammedGhallab/spring-boot
that referenced
this pull request
Apr 10, 2026
See spring-projectsgh-50010 Signed-off-by: MohammedGhallab <mohammedfahmiyghallab@gmail.com>
snicoll
changed the title
snicoll
added
type: documentation
See spring-projectsgh-50010 Signed-off-by: MohammedGhallab <mohammedfahmiyghallab@gmail.com>
snicoll
force-pushed
the
fix-issue-49952
branch
from
10de67c to
4670675
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The configuration metadata for
management.httpexchanges.recording.includewas inconsistent with the actual default values in the code.Changes:
errorsfromdefaultValue(not present inIncludeenum).time-takentodefaultValue(defined inInclude.defaultIncludes()).org.springframework.boot.actuate.web.exchanges.Include.Fixes #49952