Skip to content

Conversation

@jzheaux
Copy link

@jzheaux jzheaux commented Jan 21, 2026

Uses common action for GChat release announcements

Uses common action for GChat release announcements

Signed-off-by: Josh Cummings <3627351+jzheaux@users.noreply.github.com>
Copy link
Contributor

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
Thank you!

curl -X POST '${{ env.CHAT_WEBHOOK_URL }}' -H 'Content-Type: application/json' -d '{ text: "${{ github.event.repository.name }}-announcing `${{ inputs.milestone }}`"}'
env:
CHAT_WEBHOOK_URL: ${{ secrets.SPRING_RELEASE_CHAT_WEBHOOK_URL }}
if: secrets.SPRING_RELEASE_CHAT_WEBHOOK_URL != ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need != ''?
I thought if: does the trick against empty strings easily.

uses: spring-io/spring-release-actions/announce-on-gchat@0.0.1
with:
gchat-webhook-url: ${{ secrets.SPRING_RELEASE_CHAT_WEBHOOK_URL }}
project-name: ${{ github.event.repository.name }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is exactly what announce-on-gchat action does by default:

 return this._projectName || process.env.GITHUB_REPOSITORY.split("/")[1];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants