Conversation
Contributor
|
Can you submit this agains the 5.0.x branch? |
The set of already resolved context ids was JVM wide and never cleared, so a second ApplicationContext in the same JVM warned about repeated Client initialization even though every context resolved the client exactly once. Track the ids per application context instead, keyed weakly on the owning BeanFactory so closed contexts are not retained. Signed-off-by: kdelay <kdelay20@gmail.com>
kdelay
force-pushed
the
fix/scope-client-init-warning-to-application-context
branch
from
September 16, 2026 00:48
16c6f00 to
fddd1ee
Compare
Author
|
Retargeted to 5.0.x in fddd1ee. The commit cherry-picked cleanly. On 5.0.x the new test fails without the fix (FeignClientFactoryBeanTests.java:61, the captured log still contains the repeated-initialization warning) and passes with it; ./mvnw -pl spring-cloud-openfeign-core verify gives 443 tests, 0 failures, 0 checkstyle violations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FeignClientFactoryBeantracks resolved context ids in aprivate static final Set, so the "is being initialized more than once. Ensure the Client bean is Singleton scoped" warning is JVM-wide and never cleared.A second
ApplicationContextin the same JVM, which is normal in a Spring Boot test suite or after@DirtiesContext, resolves theClientfor a context id exactly once and still warns. The advice is wrong there: the bean is singleton scoped.The detection is unchanged. The set is now per application context, keyed weakly on the owning
BeanFactoryso closed contexts are not retained.FeignClientFactoryBeanTestscovers both sides: a second resolution inside one context still warns, two separate contexts do not. The second test fails onmainand passes here.